fix(compiler): _interopNamespace not defined in cjs#6272
Merged
christian-bromann merged 1 commit intostenciljs:mainfrom Jun 3, 2025
Merged
Conversation
…ction is enabled When config.extras.enableImportInjection (or experimentalImportInjection) is enabled, set Rollup's interop: 'auto' and dynamicImportInCjs: false in the CJS output options. This ensures that Rollup generates the _interopNamespace helper for proper ESM/CJS interoperability.
christian-bromann
approved these changes
Jun 2, 2025
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Awesome, thanks a lot!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
When set
enableImportInjection, this code uses_interopNamespacerollup helpercore/src/compiler/output-targets/dist-lazy/generate-lazy-module.ts
Lines 175 to 181 in 33363d4
After Rollup upgrade currently CJS build with this flag enabled, don't have the rollup helper.
GitHub Issue Number: #6270
What is the new behavior?
Basically we are making sure that it is generating the _interopNamespace when the
enableImportInjectionsetting is being used.Documentation
Rollup Interop
Rollup Dynamic Import is the new default
Does this introduce a breaking change?
Testing
Generate a dev stencil build, link with npm link, and test inside the issue repo.
Check the index.js that loader.cjs uses
Other information