feat(hydrate): add serializeShadowroot to hydrateDocument#6259
Merged
christian-bromann merged 2 commits intostenciljs:mainfrom May 23, 2025
Merged
Conversation
e00c071 to
eda4107
Compare
f022830 to
db595bc
Compare
serializeShadowroot to hydrateDocument
serializeShadowroot to hydrateDocumentserializeShadowroot to hydrateDocument
Member
|
@Armand-Lluka it seems like the e2e tests are failing: |
d64cdca to
09327e0
Compare
Contributor
Author
|
Looks like I was running the wrong test suite 🙈 I've updated the type in |
09327e0 to
a9a89eb
Compare
christian-bromann
requested changes
May 23, 2025
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Last request: can we remove serializeShadowRoot from SerializeDocumentOptions since it extends HydrateDocumentOptions where it is now being defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: #6240
What is the new behavior?
hydrateDocumenthas been extended to provide theserializeShadowRootopt to be inline with what is provided withrenderToStringDocumentation
Does this introduce a breaking change?
Testing
Test was added to
test.e2e.tsto verify the new optionOther information