Changed hash algorithm in screenshot-compare to sha256#6258
Merged
christian-bromann merged 2 commits intostenciljs:mainfrom May 27, 2025
Merged
Changed hash algorithm in screenshot-compare to sha256#6258christian-bromann merged 2 commits intostenciljs:mainfrom
christian-bromann merged 2 commits intostenciljs:mainfrom
Conversation
christian-bromann
approved these changes
May 27, 2025
Member
christian-bromann
left a comment
There was a problem hiding this comment.
This change make sense, however it will be breaking change for users since the hash will be different for all images them after the update. I will put this into a minor release as screenshot testing is still marked "experimental".
Note: we are likely gonna deprecate this feature within the next major release as alternative testing tools like WebdriverIO or Playwright provide a better feature set for visual tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Screenshot compare function uses md5 hash algorithm
GitHub Issue Number: 6241
https://csrc.nist.rip/library/NIST%20SP%20800-107%20Recommendation%20for%20Applications%20Using%20Approved%20Hash%20Algorithms,%202009-02%20(2).pdf#:~:text=hash%20algorithm%20is%20used%20to%20map%20a%20message,hash%20algorithms%3A%20SHA-1%2C%20SHA-224%2C%20SHA-256%2C%20SHA-384%2C%20and%20SHA-512.
What is the new behavior?
Changes from md5 to sha256 as md5 is not available in environments that need FIPS compliance (or have restrictions against older hash functions with collision risks ... such as within chainguard builder images etc)
Documentation
#6241
Does this introduce a breaking change?
Testing
Other information