Skip to content

fix(build): fix build after dependency updates#6251

Merged
christian-bromann merged 3 commits intomainfrom
cb/fix-build
May 6, 2025
Merged

fix(build): fix build after dependency updates#6251
christian-bromann merged 3 commits intomainfrom
cb/fix-build

Conversation

@christian-bromann
Copy link
Copy Markdown
Member

What is the current behavior?

The build is failing due to a TypeScript issue in the component tests:

[ ERROR ]  TypeScript: node_modules/puppeteer/lib/types.d.ts:8:25
           Cannot find module 'chromium-bidi/protocol/protocol.js' or its
           corresponding type declarations.There are types at
           '/home/runner/work/core/core/tmp-component-starter/node_modules/chromium-bidi/lib/esm/protocol/protocol.d.ts',
           but this result could not be resolved under your current
           'moduleResolution' setting. Consider updating to 'node[16](https://github.com/stenciljs/core/actions/runs/14845459798/job/41686072470?pr=6249#step:16:17)',
           'nodenext', or 'bundler'.

      L7:  import type { ProtocolMapping } from 'devtools-protocol/types/protocol-mapping.js';
      L8:  import { Session } from 'chromium-bidi/protocol/protocol.js';

What is the new behavior?

Update the module resolution to bundler and update some ws type usage.

Documentation

n/a

Does this introduce a breaking change?

  • Yes
  • No

Testing

n/a

Other information

n/a

@christian-bromann christian-bromann requested a review from a team as a code owner May 5, 2025 23:22
@christian-bromann christian-bromann merged commit d0c5ce5 into main May 6, 2025
142 of 144 checks passed
@christian-bromann christian-bromann deleted the cb/fix-build branch May 6, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant