Skip to content

fix(loader): remove package.json as it interferes with main#6200

Merged
christian-bromann merged 1 commit intostenciljs:mainfrom
johnjenkins:rv-loader-package
Mar 12, 2025
Merged

fix(loader): remove package.json as it interferes with main#6200
christian-bromann merged 1 commit intostenciljs:mainfrom
johnjenkins:rv-loader-package

Conversation

@johnjenkins
Copy link
Copy Markdown
Contributor

@johnjenkins johnjenkins commented Mar 12, 2025

The auto-generated package.json that Stencil inserts within the loader dir seems unnecessary now.

What is the current behavior?

The auto-generated package.json:

  • overrules settings within the main package.json leading to unexpected behaviour
  • removes developer wishes and agency - "I should control how & what is exported"

GitHub Issue Number: #5637 < the fix was merely a stop gap and is not a 'modern' solution (node now supports es modules natively)

What is the new behavior?

Stop stencil inserting the loader package.json

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@johnjenkins johnjenkins requested a review from a team as a code owner March 12, 2025 22:57
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit bad6e1e into stenciljs:main Mar 12, 2025
141 of 142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants