fix(compiler): get to handle .cts files#6199
Merged
christian-bromann merged 7 commits intomainfrom Mar 13, 2025
Merged
Conversation
3 tasks
Contributor
|
hey @christian-bromann - do we need to add the Do we also need to update this line too to cope with these types? Line 50 in e2965e5 Then I wonder if we could use one of these utils to replace all the inline checks in the if statements? |
Member
Author
|
@johnjenkins good catch, I reorganised some stuff around, wdyt? |
Contributor
|
@christian-bromann - just some ideas .. perhaps practically they can't work 'cos the code exists at different times or whatever |
johnjenkins
approved these changes
Mar 12, 2025
Contributor
johnjenkins
left a comment
There was a problem hiding this comment.
presume my micro suggestions aren't workable / not practical? Tiny thing anyway - LGTM 🙂
Member
Author
|
I wasn't quite sure what you were referring to but you are right, updated the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
fixes #6198
What is the new behavior?
Considers
.ctsfiles now as well.Documentation
Does this introduce a breaking change?
Testing
n/a
Other information
n/a