build: update rollup to latest#6187
Merged
christian-bromann merged 6 commits intostenciljs:mainfrom Mar 11, 2025
Merged
Conversation
Contributor
Author
|
ci broken - not sure why |
Contributor
Author
|
what do you think @christian-bromann ? |
This was referenced Mar 11, 2025
Closed
|
@johnjenkins @christian-bromann |
Member
|
@a7medm7med thanks for the feedback, mind raising a quick issue? |
|
@christian-bromann |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Rollup ~2
GitHub Issue Number: N/A
What is the new behavior?
Rollup >4
Documentation
Does this introduce a breaking change?
Testing
Tests continue to pass
Other information
One thing ... Stencil used to use
cutomResolveOptionswithin@rollup/plugin-node-resolve"to route fs to it's in-memory fs. However the rollup plugin removed this ability in version11.0.0. Initial tests doesn't appear to affect bundle performance - if anything it seems faster.However, there is a new
resolvehook which perhaps I can explore if necessary