fix(runtime): mock querySelectorAll#6175
Merged
christian-bromann merged 6 commits intomainfrom Feb 25, 2025
Merged
Conversation
4 tasks
Contributor
There was a problem hiding this comment.
@christian-bromann Totally fine to close my PR 👍
8 tasks
johnjenkins
reviewed
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Importing the
dist-custom-elementscomponents in Node.js is failing due to thedoc.querySelectorAllinhydrateScopedToShadow. This can cause issues when SSR components in Next.js.What is the new behavior?
Enhance the document mock with an additional method to make the function a noop and fix the failure.
Documentation
Does this introduce a breaking change?
Testing
Added an e2e test for this.
Other information
cc @johnjenkins