Skip to content

Introduce --tls flag for command check grpc#456

Merged
stefanprodan merged 1 commit intostefanprodan:masterfrom
matheuscscp:check-grpc-tls
Mar 3, 2026
Merged

Introduce --tls flag for command check grpc#456
stefanprodan merged 1 commit intostefanprodan:masterfrom
matheuscscp:check-grpc-tls

Conversation

@matheuscscp
Copy link
Copy Markdown
Contributor

This flag makes the check work correctly with podinfo's gRPC endpoint when served over TLS. I'm also replacing the deprecated grpc.Dial() with the recommended alternative grpc.NewClient() and fixing a typo.

Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
Copy link
Copy Markdown
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit e15511a into stefanprodan:master Mar 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants