Skip to content

Prepare release 17.1.0#1908

Merged
voxpelli merged 2 commits intomasterfrom
prepare-17-1-0
May 30, 2023
Merged

Prepare release 17.1.0#1908
voxpelli merged 2 commits intomasterfrom
prepare-17-1-0

Conversation

@voxpelli
Copy link
Copy Markdown
Member

@voxpelli voxpelli commented May 29, 2023

No description provided.

@voxpelli voxpelli self-assigned this May 29, 2023
@socket-security
Copy link
Copy Markdown

socket-security bot commented May 29, 2023 •
edited
Loading

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: eslint-config-standard@17.0.0

@voxpelli
Downgrade to eslint-plugin-n to avoid breaking
e3ca26b 
Else would need to drop Node <16
@voxpelli voxpelli requested review from LinusU, bcomnes and theoludwig May 29, 2023 16:22
theoludwig
theoludwig approved these changes May 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

The external tests failing is not related to us, we might need to disable it.

LinusU
LinusU reviewed May 29, 2023
View reviewed changes
package.json
"eslint-plugin-promise": "^6.0.0",
"eslint-plugin-react": "^7.28.0",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-n": "^15.7.0",
Copy link
Copy Markdown
Member

@LinusU LinusU May 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump/allow 16.x here?

Suggested change
"eslint-plugin-n": "^15.7.0",
"eslint-plugin-n": "^15.7.0 || ^16.0.0",

Copy link
Copy Markdown
Member Author

@voxpelli voxpelli May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LinusU We can't without bumping the required Node to 16, and that would require us to release as Standard 18

LinusU
LinusU approved these changes May 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@voxpelli voxpelli merged commit a4049f8 into master May 30, 2023
@voxpelli voxpelli deleted the prepare-17-1-0 branch May 30, 2023 14:18
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Merged
@standard standard deleted a comment from Marcy336 Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LinusU LinusU LinusU approved these changes

@bcomnes bcomnes Awaiting requested review from bcomnes

+1 more reviewer

@theoludwig theoludwig theoludwig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@voxpelli voxpelli

Labels

None yet

Projects

The Standard Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@voxpelli @LinusU @theoludwig @bngonyama1322