Skip to content

Improve code-review-assist skill for clearer reviews#4424

Merged
jerm-dro merged 1 commit intomainfrom
jerm/improve-code-review-assist-skill-v2
Mar 30, 2026
Merged

Improve code-review-assist skill for clearer reviews#4424
jerm-dro merged 1 commit intomainfrom
jerm/improve-code-review-assist-skill-v2

Conversation

@jerm-dro
Copy link
Copy Markdown
Contributor

Summary

The review output from the code-review-assist skill was overwhelming — it jumped straight into detailed questions without establishing context, making it hard for reviewers to orient themselves before evaluating concerns. These changes restructure the skill so reviewers build a mental model of the code before seeing concerns, and every concern communicates its severity clearly.

Type of change

  • Enhancement to an existing feature

Changes

File Change
.claude/skills/code-review-assist/SKILL.md Restructured session planning and review output format

Session planning

  • Only load PR metadata (not diffs) during planning for speed
  • Default merged-PR lookback to 2 days instead of unbounded
  • Surface existing review activity (approvals, pending reviews, comments)
  • Identify and group stacked PRs with their dependency chains
  • Present PRs one at a time during review sessions

Review structure

  • New: Background section — reads original files and maps owners (types, interfaces, functions) to named responsibilities (behavioral contracts), establishing terminology for the rest of the review
  • New: Important Changes section — frames the diff as a conceptual delta on the ownership/responsibility map (new owners, new responsibilities, shifted responsibilities, modified responsibilities)
  • Renamed: Key Concerns (was "Key Review Questions") — each concern now uses conventional comment severity labels (blocker:, suggestion:, question:, nitpick:)
  • Replaced: "Things That Look Fine" with a Recommendation (approve, request changes, or skip) grounded in the key concerns

Test plan

  • Invoke /code-review-assist without arguments and verify session planning loads only metadata
  • Invoke /code-review-assist <PR> and verify the Background section establishes owners/responsibilities before diving into changes
  • Verify Key Concerns use conventional comment severity labels
  • Verify review ends with a Recommendation

Does this introduce a user-facing change?

Review sessions now provide a structured conceptual ramp (summary → background → changes → concerns → recommendation) instead of jumping directly into detailed questions, making it easier to understand PRs before evaluating them.

Generated with Claude Code

The review output was overwhelming — it jumped straight into detailed
questions without establishing context, making it hard for reviewers to
orient themselves conceptually before evaluating concerns.

Session planning changes:
- Only load PR metadata (not diffs) during planning to keep it fast
- Default merged-PR lookback to 2 days instead of unbounded
- Surface existing review activity and stacked PR relationships
- Present PRs one at a time during the session

Review structure changes:
- Add Background section that maps owners to named responsibilities
  by reading the original files, not just the diff
- Add Important Changes section that frames the diff as a conceptual
  delta on the ownership/responsibility map
- Rename "Key Review Questions" to "Key Concerns" with conventional
  comment severity labels (blocker, suggestion, question, nitpick)
- Replace "Things That Look Fine" with a Recommendation (approve,
  request changes, or skip) grounded in the concerns

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Mar 29, 2026
@jerm-dro jerm-dro requested a review from yrobla March 29, 2026 20:14
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.52%. Comparing base (19eeb6b) to head (f8a1518).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4424      +/-   ##
==========================================
+ Coverage   69.49%   69.52%   +0.03%     
==========================================
  Files         486      486              
  Lines       50017    50017              
==========================================
+ Hits        34760    34776      +16     
+ Misses      12574    12558      -16     
  Partials     2683     2683              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jerm-dro jerm-dro merged commit feef6ed into main Mar 30, 2026
37 checks passed
@jerm-dro jerm-dro deleted the jerm/improve-code-review-assist-skill-v2 branch March 30, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants