Fix macOS symlink test failures and upgrade phonenumbers dependency#4399
Merged
Fix macOS symlink test failures and upgrade phonenumbers dependency#4399
Conversation
On macOS, t.TempDir() returns paths under /var/folders which is a symlink to /private/var. This caused two test failures: - skillsvc tests failed because the skill extractor rejects paths containing symlinks; fix by resolving via EvalSymlinks using the existing tempDir(t) helper - health_test unix socket test failed because the resolved path exceeded macOS's 104-char socket path limit; fix by using os.MkdirTemp with a short prefix Also upgrades github.com/nyaruka/phonenumbers from v1.1.6 to v1.6.12 to resolve GHSA-fmjh-f678-cv3x (Medium). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4399 +/- ##
=======================================
Coverage 69.51% 69.51%
=======================================
Files 485 485
Lines 49805 49805
=======================================
+ Hits 34623 34624 +1
- Misses 12503 12509 +6
+ Partials 2679 2672 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rdimitrov
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t.TempDir()returns paths under/var/folders/..., which is a symlink to/private/var/.... The skill extractor rejects paths containing symlinks, and the resolved path also exceeded macOS's 104-char Unix socket path limit.github.com/nyaruka/phonenumbersfrom v1.1.6 to v1.6.12 to resolve GHSA-fmjh-f678-cv3x (Medium severity).Changes
tempDir(t)helper (callsfilepath.EvalSymlinks) insetupPRclosures so extracted skill paths pass symlink validationos.MkdirTemp("", "thv-")for the Unix socket test to produce a short path that fits within macOS's 104-char limitgithub.com/nyaruka/phonenumbersv1.1.6 → v1.6.12Type of change
Test plan
task testpasses locally with no failuresDoes this introduce a user-facing change?
No
Generated with Claude Code