Add AuthServerConfig validation condition to VirtualMCPServer reconciler#4350
Merged
Add AuthServerConfig validation condition to VirtualMCPServer reconciler#4350
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4350 +/- ##
==========================================
+ Coverage 69.55% 69.58% +0.02%
==========================================
Files 480 480
Lines 48837 48978 +141
==========================================
+ Hits 33971 34080 +109
- Misses 12249 12274 +25
- Partials 2617 2624 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tgrunnagle
previously approved these changes
Mar 24, 2026
d447384 to
39a9a1e
Compare
- Add RuntimeConfig and AuthServerConfig wrapper types to config model (runtime-only, not part of CRD schema) - Set AuthServerConfigValidated condition in reconciler when inline AuthServerConfig is present on the spec - Add E2E test for AuthServerConfigValidated condition lifecycle Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…on lifecycle Move AuthServerConfig validation from Validate() into a dedicated reconciler method that sets AuthServerConfigValidated condition on both success (True) and failure (False), matching the pattern used by validateGroupRef. This wires up the previously unused ConditionReasonAuthServerConfigInvalid constant and clears stale conditions when AuthServerConfig is removed from the spec. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
244236f to
e8a7a1b
Compare
tgrunnagle
previously approved these changes
Mar 25, 2026
The validateAuthServerConfig method on *VirtualMCPServer was only called from tests — the real validation with condition lifecycle lives in the reconciler. Remove the duplicate method and its test. Also drop the unused receiver name on the reconciler method to fix the revive lint. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tgrunnagle
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthServerConfig, the operator should validate it during reconciliation and surface the result as a status condition.AuthServerConfigValidatedcondition to the VirtualMCPServer reconciler that is set when inline AuthServerConfig is present on the spec.SetAuthServerConfigValidatedConditionto the status collector interface.Fixes: #4143
Type of change
Test plan
task test)task lint-fix)virtualmcp_authserver_config_test.go)Special notes for reviewers
Draft — stacked on #4349. Review the incremental diff only.
Generated with Claude Code