Increase session management E2E test timeout to 3 minutes#4344
Merged
Conversation
The session management tests used a 2-minute timeout for WaitForVirtualMCPServerReady, while all other VirtualMCPServer E2E tests use 3 minutes. With the default 30-second health check interval and 3-failure unhealthy threshold, the health monitor needs up to 150 seconds to detect backend readiness if the first check fails during pod startup — exceeding the 2-minute window and causing flaky "All backends are unhealthy" timeouts under CI load. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4344 +/- ##
==========================================
- Coverage 68.95% 68.90% -0.06%
==========================================
Files 479 479
Lines 48489 48489
==========================================
- Hits 33438 33412 -26
- Misses 12317 12343 +26
Partials 2734 2734 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amirejaz
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The session management E2E tests were the only VirtualMCPServer tests using a 2-minute timeout for
WaitForVirtualMCPServerReady— all other tests use 3 minutes. Under CI load (this test runs as spec ~120/121), backend pod startup can be slow enough that the health monitor accumulates 3 failures (at 30-second default intervals) before the backend is reachable. Recovery from unhealthy state requires 2 additional successful checks (another 60 seconds), pushing the total past the 2-minute window and causing a timeout with "All backends are unhealthy".timeoutfrom 2 minutes to 3 minutes, matching all other VirtualMCPServer E2E testsType of change
Test plan
Special notes for reviewers
The worst-case health monitor timeline with default settings (30s interval, threshold 3):
countBackendHealth)With 2-minute timeout, the test races against this 150-second worst case. With 3 minutes, there is comfortable headroom. A deeper fix could configure shorter health check intervals on the test's VirtualMCPServer (like the circuit breaker and external auth tests do with 5s intervals), but the timeout alignment is the minimal safe change.
Generated with Claude Code