Merged
Conversation
58c34a7 to
3427bb0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4332 +/- ##
==========================================
- Coverage 69.08% 68.97% -0.11%
==========================================
Files 478 478
Lines 48432 48484 +52
==========================================
- Hits 33457 33444 -13
+ Misses 12314 12306 -8
- Partials 2661 2734 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When E2E tests fail in CI, we lacked the information needed to diagnose root causes. This adds three improvements: 1. Generate JUnit XML reports by passing --junit-report to ginkgo, and enable --vv in CI for verbose step timelines on failure. 2. Dump thv serve stdout/stderr via GinkgoWriter when a test fails, so server-side errors appear in the test output. 3. Add ExpectStatus helper that includes the response body in assertion failure messages, making HTTP error responses visible. 4. Remove the never-generated ginkgo-report.xml from artifact uploads. Closes #4077 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
3427bb0 to
5100e27
Compare
yrobla
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thv serveoutput isn't captured, and Ginkgo report files are never generated. This addresses all four improvements proposed in Improve E2E test debuggability in CI #4077.ExpectStatushelper for response-body-aware assertions.Closes #4077
Type of change
Test plan
task lint-fix)Verified all changes compile with
go vet ./test/e2e/.... The JUnit report generation and server log dumping will be validated by the E2E tests in this PR's CI run — if a test fails, the JUnit XML artifact should now be uploaded and server logs should appear in the Ginkgo output.Changes
test/e2e/run_tests.sh--junit-reportand--vvflags to ginkgo in CItest/e2e/api_helpers.gothv servestdout/stderr on test failure; addExpectStatushelper.github/workflows/e2e-tests.ymlginkgo-report.xmlfrom artifact uploadDoes this introduce a user-facing change?
No
Special notes for reviewers
The
ExpectStatushelper is available for adoption in test files incrementally — existing assertions continue to work. The server log dumping only fires whenCurrentSpecReport().Failed()is true, so successful test runs produce no extra output.Generated with Claude Code