Add remaining Claude Code subagent definitions#4060
Conversation
Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
|
@rdimitrov needs another tick. I had to push up the "Claude" proof version of them |
| - Separate business logic from transport/protocol concerns | ||
| - Keep packages focused on single responsibilities | ||
|
|
||
| **Error Handling:** |
There was a problem hiding this comment.
should we remove the duplicate stuff from claude.md?
| - MCP Protocol: `github.com/mark3labs/mcp-go` | ||
| - Web Framework: Chi router (`github.com/go-chi/chi/v5`) | ||
| - CLI: Cobra, Configuration: Viper | ||
| - Testing: Ginkgo/Gomega, `go.uber.org/mock` |
There was a problem hiding this comment.
just fyi - (no action requested / previous job) I had migrated from uber/mock to mockery https://github.com/vektra/mockery, since uber/mock doesn't seem to be actively maintained, also a few cleaner improvements
| {name: "empty input", input: "", wantErr: true}, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { |
There was a problem hiding this comment.
also I've used the triple-a (arrange-act-assert) pattern which found useful (just something to consider)
| @@ -0,0 +1,128 @@ | |||
| --- | |||
| name: unit-test-writer | |||
There was a problem hiding this comment.
one of the things I've noticed is sometimes Claude writing unit tests for private/helper methods, it's generally/mostly advised to not test private/helper methods directly but indirectly through the public/exported methods. Is this something we could consider or what's the current convention?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4060 +/- ##
==========================================
+ Coverage 68.61% 68.69% +0.07%
==========================================
Files 446 446
Lines 45435 45435
==========================================
+ Hits 31176 31210 +34
+ Misses 11850 11818 -32
+ Partials 2409 2407 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
The CLAUDE.md file references several specialized subagents that were not yet
defined in
.claude/agents/. This adds the five missing agent definitions soClaude Code can invoke them for domain-specific tasks.
Type of change
Test plan
Verified that Claude Code correctly discovers and invokes the new subagents
when prompted with tasks matching their descriptions.
Does this introduce a user-facing change?
No. These are internal Claude Code agent definitions that improve AI-assisted
development workflows.
🤖 Generated with Claude Code