Simplify nested tables#46
Merged
cyyynthia merged 3 commits intosquirrelchat:mistressfrom Nov 13, 2025
Merged
Conversation
6 tasks
petebacondarwin
approved these changes
Nov 13, 2025
cyyynthia
approved these changes
Nov 13, 2025
Member
cyyynthia
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I took the initiative to refactor it so there is only a single iteration over the table's keys, which makes the performance impact of this change almost negligible.
Thanks for the tests too! 🩷
Member
|
v1.5.0 is now released with this change. Thanks again for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of trying to migrate to
smol-tomlfrom@iarna/tomlin Cloudflare's Wrangler, we've been running into some differences in howsmol-tomlrenders nested tables when stringifying. For instance, the following object:is rendered by
smol-tomlasand by
@iarna/tomlasBoth are valid, but the
@iarna/tomloutput seems clearer and easier to work with. As such, this PR modifies thesmol-tomlstringify logic to not render a table key if: