Add warning for dotfiles in info plugin#7142
Conversation
|
PR looks good so far, thanks! This also means that a |
0e8b959 to
60e6afc
Compare
60e6afc to
f724bb9
Compare
|
I removed the second list, and instead changed the color of the dotpaths. This has lead to creating a second list anyway, because the file names are sorted, and the yellow color has a higher ANSI value, therefore all dotpaths are ordered last. I also removed some conditionals, when clearing the indicator, because it turned out to be unnecessary. I wanted to print a count of the dotpaths, but the results highlight also the contents of dotdirectories, so the count wouldn't match from what was initially detected, to keep it simple I don't count anything now. I think it's cleaner than the initial PR, but let me know what you think ✌️
Yes, I didn't really plan to handle such cases, because we'd have to read config setting from other plugins. Even though it's only |
squidfunk
left a comment
There was a problem hiding this comment.
Thanks! I guess we can give it a spin and see if reports for .meta.yml and other non-critical files lead to confusion. The info plugin is something we should try different approaches on until we find the one that works best
|
@kamilkrzyskow you can merge it if it's ready to go 🚀 |
|
Okey dokey 👌 |
Attempt at handling #7125
I admit the PR is a bit "noisy", for such a small feature, but I think this is the best I can do, given that there are 2 separate
forloops for directory/files paths.There are 2 warnings, during the processing phase and later in the summary. I want to make sure people see it.
Perhaps the display of the list at the end is unnecessary and not so convenient, as I think it is?
EDIT:
I will try to modify the actual summary file list and change color of the dotfiles. This should remove the need for another list.