Work around annotation icon rotation bug on Firefox#5937
Work around annotation icon rotation bug on Firefox#5937squidfunk merged 2 commits intosquidfunk:masterfrom
Conversation
squidfunk
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a minor question
| // Hack: Work around Firefox bug that renders a subpixel outline when | ||
| // rotating a mask image element. | ||
| // https://bugzilla.mozilla.org/show_bug.cgi?id=1671784 | ||
| overflow: hidden; // stylelint-disable-line |
There was a problem hiding this comment.
Why does stylelint need to be disabled here?
There was a problem hiding this comment.
Because it complains otherwise:
Expected "overflow" to come before "outline" order/properties-order
And I thought it's good to keep this hack separate from other styles, starting with a comment, to remember later that this is a hack and to ease its removal at some point when Firefox has fixed the bug and enough time has passed to justify dropping support for an old buggy Firefox version.
There was a problem hiding this comment.
We should move it into the right location and keep the comment above the property, exactly as we do it with other hacks we have in place, e.g.:
mkdocs-material/src/assets/stylesheets/main/components/_base.scss
Lines 29 to 37 in 8f1433f
There was a problem hiding this comment.
I see. But then the two relevant styles are not collocated, so the comment needs to be duplicated. Is this how you would like it?
There was a problem hiding this comment.
Valid point. Then please only disable the specific rule with stylelint, not the entirety of stylelint, as we'd be losing linting of other errors otherwise.
There was a problem hiding this comment.
Good idea. I've pushed an update as you suggested.
3efe96c to
b82006d
Compare
b82006d to
ec1615d
Compare
|
Thanks! |
I've added a workaround for a Firefox bug that renders a subpixel outline when rotating a mask image element – in this case the annotation icon: