Add missing comma to light-mode selector example#5632
Merged
squidfunk merged 1 commit intosquidfunk:masterfrom Jun 23, 2023
charliermarsh:charliermarsh-patch-1
Merged
Add missing comma to light-mode selector example#5632squidfunk merged 1 commit intosquidfunk:masterfrom charliermarsh:charliermarsh-patch-1
squidfunk merged 1 commit intosquidfunk:masterfrom
charliermarsh:charliermarsh-patch-1
Conversation
Owner
|
Thanks for the PR! Jup, there needs to be a comma. Good catch! Oh, and I'm psyched to see Ruff use Material for MkDocs! |
Contributor
Author
|
Of course! I will admit that I didn't look into it deeply, but I also had to add this (I believe only the latter was necessary -- dark-mode-only images still had [data-md-color-scheme="astral-light"] img[src$="#only-light"],
[data-md-color-scheme="astral-light"] img[src$="#gh-light-mode-only"] {
display: inline; /* Show light images in light mode */
}
[data-md-color-scheme="astral-dark"] img[src$="#only-dark"],
[data-md-color-scheme="astral-dark"] img[src$="#gh-dark-mode-only"] {
display: inline; /* Show dark images in dark mode */
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dark-mode example (a few lines below) has a comma here, but the light-mode example does not. I think it's just missing, since IIUC this should be an "OR" query.
Thanks for the great project! (We use
mkdocs-materialto power the Ruff documentation.)