Use a single synchronized block in Dispatcher#9110
Merged
Conversation
Previously we had synchronized blocks preceding calls to promoteAndExecute, plus the synchronized blocks in that function itself. This is intended to make it easier to publishg the right events for dispatcherQueueStart and dispatcherQueueEnd when an enqueued call can skip the queue. Also note that this should fix some corner-cases around unnecessary calls to idleCallback when the executor is already shut down.
swankjesse
commented
Oct 6, 2025
|
|
||
| asyncCall.failRejected() | ||
| } | ||
| idleCallback?.run() |
Collaborator
Author
There was a problem hiding this comment.
I believe this would have triggered unnecessary calls to the idle callback. For example, each time maxRequests is mutated, this would be called if the executor service was shut down, even if it was already idle.
yschimke
approved these changes
Oct 6, 2025
yschimke
left a comment
Collaborator
There was a problem hiding this comment.
It's a tough review, but I think our tests and lock checks make this safe. We should pay attention to flakes
| while (i.hasNext()) { | ||
| val asyncCall = i.next() | ||
| // Actions to take outside the synchronized block. | ||
| class Effects( |
Collaborator
There was a problem hiding this comment.
I like this pattern across barriers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we had synchronized blocks preceding calls to promoteAndExecute, plus the synchronized blocks in that function itself.
This is intended to make it easier to publishg the right events for dispatcherQueueStart and dispatcherQueueEnd when an enqueued call can skip the queue.
Also note that this should fix some corner-cases around unnecessary calls to idleCallback when the executor is already shut down.