Add support for Context Parameters (#2094)#2112
Merged
Egorand merged 7 commits intosquare:mainfrom Apr 17, 2025
Merged
Conversation
vlsi
approved these changes
Apr 16, 2025
vlsi
left a comment
There was a problem hiding this comment.
Looks good, and it seems to cover both positive and negative cases
Egorand
reviewed
Apr 16, 2025
Collaborator
Egorand
left a comment
There was a problem hiding this comment.
Thanks, this looks great, and I really appreciate how thorough the test coverage is. Left some comments to address, and I'd suggest moving context receiver deprecation into a separate PR. With that, it should be good to merge!
Egorand
reviewed
Apr 16, 2025
Egorand
reviewed
Apr 16, 2025
Co-authored-by: Egor Andreevich <github@egorand.dev>
Egorand
reviewed
Apr 16, 2025
Egorand
reviewed
Apr 16, 2025
Egorand
approved these changes
Apr 16, 2025
Collaborator
Egorand
left a comment
There was a problem hiding this comment.
Thank you, looks great!
This was referenced Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdhas been updated if applicable.be added to the changelog.