Fix javadoc for migration from WebSecurityConfigurerAdapter#12996
Merged
Conversation
Collaborator
|
@xak2000, thanks for the PR. We've recently changed to use forward porting. To that end, will you please rebase this PR to |
Contributor
Author
|
@jzheaux Rebased the PR to |
Collaborator
|
Thanks for checking, @xak2000. No need to do a fresh rebase. This is now merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just fixes the code sample in javadocs that errorneously uses
WebSecurityparameter in a bean-creation method that doesn't need to have any parameters, asWebSecurityparameter is already provided inWebSecurityCustomizer.customize(WebSecurity web)functional method. Moreover, the sample doesn't even compile because of parameter names collision (the bean factory paramter and lambda parameter).This fix could also be backported to 5.7.x branch.