Skip to content

Add test to SimpleUrlAuthenticationSuccessHandlerTests#12740

Merged
jzheaux merged 1 commit into
spring-projects:5.7.xfrom
twosom:add-post-process-validate-on-simple-url-authentication-fileter
Mar 20, 2023
Merged

Add test to SimpleUrlAuthenticationSuccessHandlerTests#12740
jzheaux merged 1 commit into
spring-projects:5.7.xfrom
twosom:add-post-process-validate-on-simple-url-authentication-fileter

Conversation

@twosom

@twosom twosom commented Feb 18, 2023

Copy link
Copy Markdown
Contributor

In the onAuthenticationSuccess method of the SimpleUrlAuthenticationSuccessHandler, the clearAuthenticationAttributes method is used to remove AuthenticationException objects that may be left in the session.

However, since there was no verification of whether this logic was working properly in test cases of SimpleUrlAuthenticationSuccessHandler, I added tests to verify it.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 18, 2023
@twosom twosom force-pushed the add-post-process-validate-on-simple-url-authentication-fileter branch from d1ff26d to 1386216 Compare February 18, 2023 06:34
@jzheaux

jzheaux commented Mar 7, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the PR, @twosom! So that we can confirm that this feature continues to work on all branches, will you please rebase this off of 5.7.x? Then when we merge, I'll forward port this to 5.8.x, 6.0.x, and main.

@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 7, 2023
@jzheaux jzheaux added this to the 5.7.x milestone Mar 7, 2023
@twosom twosom force-pushed the add-post-process-validate-on-simple-url-authentication-fileter branch from 1386216 to ebdd16e Compare March 8, 2023 14:05
@twosom twosom changed the base branch from main to 5.7.x March 8, 2023 14:06
@twosom twosom force-pushed the add-post-process-validate-on-simple-url-authentication-fileter branch from ebdd16e to 702e370 Compare March 8, 2023 14:09
@twosom

twosom commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the PR, @twosom! So that we can confirm that this feature continues to work on all branches, will you please rebase this off of 5.7.x? Then when we merge, I'll forward port this to 5.8.x, 6.0.x, and main.

Thanks @jzheaux! I rebased it to 5.7.x :-)

@jzheaux jzheaux modified the milestones: 5.7.x, 5.7.8 Mar 20, 2023
@jzheaux jzheaux self-assigned this Mar 20, 2023
@jzheaux jzheaux merged commit 3d7e22a into spring-projects:5.7.x Mar 20, 2023
@jzheaux

jzheaux commented Mar 20, 2023

Copy link
Copy Markdown
Collaborator

Thanks, @twosom! This is now merged into 5.7.x, 5.8.x, 6.0.x, and main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jzheaux jzheaux

Labels

in: web An issue in web modules (web, webmvc) type: bug A general bug

Projects

None yet

Milestone

5.7.8

Development

Successfully merging this pull request may close these issues.

3 participants

@twosom @jzheaux @spring-projects-issues