Set host header consistently in STOMP relay CONNECT frames#36673
Closed
tianhaocui wants to merge 1 commit into
Closed
Set host header consistently in STOMP relay CONNECT frames#36673tianhaocui wants to merge 1 commit into
tianhaocui wants to merge 1 commit into
Conversation
StompBrokerRelayMessageHandler only set the host header in CONNECT frames when virtualHost was explicitly configured. Per STOMP 1.2, the host header is required on CONNECT frames. Fall back to relayHost (the TCP connection target) when virtualHost is not configured, ensuring the host header is always present in both system session and client session CONNECT frames. Closes spring-projects#36663 Signed-off-by: cuitianhao <54015884+tianhaocui@users.noreply.github.com>
|
I don't know if this also lead to problem like mine in other cases: Due to this change, the client could not connect to the external broker (RabbitMQ in my case) and responded with error RabbitMQ has a standard virtual host configured with name In order to fix this error I have to set the virtual host in the In my eyes this change is a breaking change and should have been mentioned somewhere. |
Contributor
|
@twiedow could you create a separate issue, and we will address it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36663
StompBrokerRelayMessageHandleronly set thehostheader in CONNECT frames whenvirtualHostwas explicitly configured. Per STOMP 1.2 specification, thehostheader is required on CONNECT frames.This change falls back to
relayHost(the TCP connection target) whenvirtualHostis not configured, ensuring thehostheader is always present in both system session and client session CONNECT frames.