spring-boot-starter-elasticsearch should depend on elasticsearch-java#48141
Closed
filiphr wants to merge 1 commit intospring-projects:mainfrom
Closed
spring-boot-starter-elasticsearch should depend on elasticsearch-java#48141filiphr wants to merge 1 commit intospring-projects:mainfrom
filiphr wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: Filip Hrisafov <filip.hrisafov@gmail.com>
dce3e1d to
0750c27
Compare
snicoll
pushed a commit
that referenced
this pull request
Nov 15, 2025
See gh-48141 Signed-off-by: Filip Hrisafov <filip.hrisafov@gmail.com>
snicoll
added a commit
that referenced
this pull request
Nov 15, 2025
Member
Contributor
Author
|
Thanks a lot @snicoll. Thanks for adjusting the docs as well, I forgot about them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I did #47945 I was not aware that there was a new spring-boot-starter-elasticsearch in Spring Boot 4. @anbusampath brought this to my attention with #47945 (comment).
I'll leave this up to the Spring Boot team to decide whether the starter should be more opinionated and bring in the High Level elasticsearch-java client. In my opinion I believe that spring-boot-elasticsearch should stay as it is, i.e. only bring in the minimal dependencies, the elasticsearch-rest5-client. However, the starter can be a bit more opinionated and bring in more.