Skip to content

DockerRegistryConfigAuthentication uses the wrong serverUrl as a fallback for the Credentials helper#45345

Closed
nosan wants to merge 1 commit intospring-projects:mainfrom
nosan:bug/3
Closed

DockerRegistryConfigAuthentication uses the wrong serverUrl as a fallback for the Credentials helper#45345
nosan wants to merge 1 commit intospring-projects:mainfrom
nosan:bug/3

Conversation

@nosan
Copy link
Contributor

@nosan nosan commented May 1, 2025

Before this commit, the credential helper used the serverUrl from the Map.Entry<String,Auth> as a fallback. However, the helper only uses the email from the auths.

Details

https://github.com/docker/cli/blob/b24e7f85a488da13dc2d5be87acdaab2652634bb/cli/config/credentials/native_store.go#L42-L56

func (c *nativeStore) Get(serverAddress string) (types.AuthConfig, error) {
	// load user email if it exist or an empty auth config.
	auth, _ := c.fileStore.Get(serverAddress)
	creds, err := c.getCredentialsFromStore(serverAddress)
	if err != nil {
		return auth, err
	}
	auth.Username = creds.Username
	auth.IdentityToken = creds.IdentityToken
	auth.Password = creds.Password
	auth.ServerAddress = creds.ServerAddress
	return auth, nil
}

@nosan
Use serverUrl from the image as a fallback for the Credentials helper
0b1d730 
Before this commit, the credential helper used the serverUrl from
the Map.Entry<String,Auth> as a fallback. However, the helper only uses
the email from the auths.

Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 1, 2025
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 1, 2025
@philwebb philwebb added this to the 3.5.x milestone May 1, 2025
@snicoll snicoll self-assigned this May 2, 2025
snicoll pushed a commit that referenced this pull request May 2, 2025
@nosan @snicoll
Use serverUrl from the image as a fallback for the Credentials helper
439dd22 
Before this commit, the credential helper used the serverUrl from
the Map.Entry<String,Auth> as a fallback. However, the helper only uses
the email from the auths.

See gh-45345

Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
@snicoll snicoll closed this in 3a51197 May 2, 2025
@snicoll snicoll modified the milestones: 3.5.x, 3.5.0 May 2, 2025
lourw pushed a commit to xiongemi/spring-boot that referenced this pull request May 13, 2025
@nosan @lourw
Use serverUrl from the image as a fallback for the Credentials helper
2413829 
Before this commit, the credential helper used the serverUrl from
the Map.Entry<String,Auth> as a fallback. However, the helper only uses
the email from the auths.

See spring-projectsgh-45345

Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
@Netyyyy Netyyyy mentioned this pull request May 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: bug A general bug

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nosan @snicoll @philwebb @spring-projects-issues