Fix incorrect command in Docker configuration for Colima#42078
Closed
martinfrancois wants to merge 1 commit intospring-projects:mainfrom
Closed
Fix incorrect command in Docker configuration for Colima#42078martinfrancois wants to merge 1 commit intospring-projects:mainfrom
martinfrancois wants to merge 1 commit intospring-projects:mainfrom
Conversation
|
@martinfrancois Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@martinfrancois Thank you for signing the Contributor License Agreement! |
Member
|
Thanks @martinfrancois, for even more clarity we could do something like this: The plugin can communicate with the Docker daemon provided by https://github.com/abiosoft/colima[Colima].
The `DOCKER_HOST` environment variable can be set by using the following command:
[source,shell,subs="verbatim,attributes"]
----
$ export DOCKER_HOST=$(docker context inspect colima -f '{{.Endpoints.docker.Host}}')
----What do you think? Are you interested in updating your PR? |
Contributor
Author
|
You're welcome, and thanks as well @philwebb, I really like the idea, makes it even clearer without introducing inconsistencies. I changed it as you suggested. |
Member
|
Thanks again @martinfrancois, this has now been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the dot is currently included in the backticks in the docs, this suggests that it should be included in the commend that should be executed as well. However, this would be incorrect, as it would result in a path that would end with a dot as well.
I put the dot after the backticks to make it clear it doesn't belong to the command. As the dot was always present in other similar instances in the docs I kept it, but if it wasn't for consistency I would be inclined to remove it entirely to make it even more foolproof.