Correct references to Jetty's HTTP2 server module#38632
Closed
gavlyukovskiy wants to merge 5 commits intospring-projects:mainfrom
Closed
Correct references to Jetty's HTTP2 server module#38632gavlyukovskiy wants to merge 5 commits intospring-projects:mainfrom
gavlyukovskiy wants to merge 5 commits intospring-projects:mainfrom
Conversation
wilkinsona
requested changes
Dec 4, 2023
Member
wilkinsona
left a comment
There was a problem hiding this comment.
Thanks for the PR, @gavlyukovskiy. Can you revert the code changes as they are unrelated to correcting the docs.
If we want to improve the diagnostics when a required dependency is missing, we may want to consider a specific exception type and a failure analyzer rather than a plain state assertion failure. For this side of things, please open an issue for consideration.
Contributor
Author
|
@wilkinsona I've reverted changes to |
wilkinsona
approved these changes
Dec 4, 2023
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update documentation to use
org.eclipse.jetty.http2:jetty-http2-serverfor Jetty HTTP2 server support.All jetty dependencies were updated in #36073, this only updates reference documentation and the exception message.