Descriptions of started and ready time metrics contain time units but the unit may change when the metrics are exported#36507
Closed
fzyzcjy wants to merge 1 commit intospring-projects:mainfrom
Closed
Conversation
|
@fzyzcjy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@fzyzcjy Thank you for signing the Contributor License Agreement! |
snicoll
pushed a commit
that referenced
this pull request
Jul 24, 2023
Member
|
@fzyzcjy good catch, thanks for making your first contribution to Spring Boot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this metric in Grafana/Prometheus, it is a bit confusing, because as the screenshot below shows, it is
application_started_time_seconds(ends with "seconds"), and the value is really measured in seconds, but the hint text say it is "ms" not "s".I guess this is because micrometer is smart enough to convert ms to s, since spring already tells micrometer it is ms.