Default for spring.flway.execute-in-transaction is not aligned with Flyway's default#35447
Closed
TheHound wants to merge 1 commit intospring-projects:mainfrom
Closed
Default for spring.flway.execute-in-transaction is not aligned with Flyway's default#35447TheHound wants to merge 1 commit intospring-projects:mainfrom
TheHound wants to merge 1 commit intospring-projects:mainfrom
Conversation
|
@TheHound Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@TheHound Thank you for signing the Contributor License Agreement! |
wilkinsona
requested changes
May 16, 2023
Member
wilkinsona
left a comment
There was a problem hiding this comment.
Thanks for catching this, @TheHound. Could you please also update defaultValuesAreConsistent in FlywayPropertiesTests to assert that the defaults are aligned?
FlywayProperties has executeInTransaction default as false, changing the org.flywaydb.core.api.configuration.Configuration#isExecuteInTransaction default. See also org.springframework.boot.autoconfigure.flyway.FlywayAutoConfiguration.FlywayConfiguration#configureProperties
c69602b to
6d8dc49
Compare
Contributor
Author
|
Updated the commit with extra line in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlywayProperties has executeInTransaction default as false, changing the org.flywaydb.core.api.configuration.Configuration#isExecuteInTransaction default. See also org.springframework.boot.autoconfigure.flyway.FlywayAutoConfiguration.FlywayConfiguration#configureProperties
Tested in 3.1.0-RC2.
Prior to change with no
spring.flywayconfiguration set