Cleanup: use Boolean.parseBoolean for string-to-boolean conversion#3217
Merged
hazendaz merged 5 commits intospotbugs:masterfrom Dec 5, 2024
Merged
Cleanup: use Boolean.parseBoolean for string-to-boolean conversion#3217hazendaz merged 5 commits intospotbugs:masterfrom
hazendaz merged 5 commits intospotbugs:masterfrom
Conversation
ThrawnCA
approved these changes
Dec 4, 2024
# Conflicts: # CHANGELOG.md # spotbugs/src/main/java/edu/umd/cs/findbugs/PluginLoader.java
ThrawnCA
reviewed
Dec 5, 2024
Contributor
There was a problem hiding this comment.
Why replace isEmpty? It seems like the better choice, O(1) instead of O(n).
Collaborator
Author
There was a problem hiding this comment.
Oops, this got back when merging. Thanks for highlighting it!
# Conflicts: # CHANGELOG.md
hazendaz
approved these changes
Dec 5, 2024
| String reports = detectorNode.valueOf("@reports"); | ||
| String requireJRE = detectorNode.valueOf("@requirejre"); | ||
| String hidden = detectorNode.valueOf("@hidden"); | ||
| if (speed == null || speed.isEmpty()) { |
Collaborator
Author
There was a problem hiding this comment.
When I merged master there was some conflict with the changes from #3219 in this file, I didn't pay enough attention and this change creeped back, so I modified this once more to be in sync with master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing "use
Boolean.parseBoolean()for string-to-boolean conversion" issues.