Use String.isEmpty() with null guards#2755
Merged
hazendaz merged 2 commits intospotbugs:masterfrom Dec 8, 2023
Merged
Conversation
There are a few places which check for null-or-empty String, where the empty part is performed with "".equals(). Rather than loading an explicit literal, use isEmpty() on the string itself, as we know it is not null. Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Sum up the change to use .isEmpty() after a null check. Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
ThrawnCA
approved these changes
Dec 7, 2023
Member
|
@ThrawnCA Actually this is faster than using string utils. And this is faster than the check it had. See internals of isEmpty() below. Its just checking the length. Other tools are already flagging the same code (believe sonar at least). |
Member
|
@rovarga Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few places which check for null-or-empty String, where
the empty part is performed with "".equals().
Rather than loading an explicit literal, use isEmpty() on the string
itself, as we know it is not null.
Signed-off-by: Robert Varga robert.varga@pantheon.tech
Before opening a 'pull request'
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code