[junit] Use junit vintage instead of junit legacy fixes #2330#2483
Merged
hazendaz merged 3 commits intospotbugs:masterfrom Jul 28, 2023
Merged
[junit] Use junit vintage instead of junit legacy fixes #2330#2483hazendaz merged 3 commits intospotbugs:masterfrom
hazendaz merged 3 commits intospotbugs:masterfrom
Conversation
behaves the same but stops directly using legacy parts so that we are firmly using modern api. Any junit 4 left then needs separately migrated to 5 as we should no longer support junit 4 in our builds.
JuditKnoll
approved these changes
Jul 24, 2023
ThrawnCA
approved these changes
Jul 24, 2023
Member
Author
|
I did accidentally mark one at 5.9.0. However, renovate will fix and 5.10.0 is now out, so merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
behaves the same but stops directly using legacy parts so that we are firmly using modern api. Any junit 4 left then needs separately migrated to 5 as we should no longer support junit 4 in our builds. Fixes #2330
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code