Would I expect to have a number of new bugs added that were not there before? Both choose visitors and omit visitors tests in the maven plugin integration suite are now failing. Normally all the integration tests just run so I'm thinking this one noting possible behaviour difference could be what did it. However, I get the same difference with single module run.
Here is test before (note this is without images)
choose-visitors-4.9.6.html
Here is the test after (note this is without images)
choose-visitors-4.9.7.html
This change seems most likely to be involved.
Integration test failures seen here
Originally posted by @hazendaz in #3753
Regression from #3753.
I couldn't find any BugReporter in maven plugin code, so I assume all output is generated somehow by FindBugs2 created via AntBuilder here:
https://github.com/spotbugs/spotbugs-maven-plugin/blob/8bedb8ee38971883cd4fcbd2801bc2a959907bc4/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy#L1157C50-L1158
This should call FindBugs2.main() and this should call TextUICommandLine and it should actually be configured here
|
for (TextUIBugReporter reporter : reporters) { |
|
reporter.setPriorityAdjuster(priorityAdjuster); |
|
} |
I believe -adjustPriority is not (always) given by maven. That would result in not created PriorityAdjuster instance. As a workaround, one can try to use something like edu.umd.cs.findbugs.detect.CheckCalls=+0 value for -adjustPriority argument (shouldn't change anything except that PriorityAdjuster would be created).
I will try to provide a fix for TextUICommandLine now.
Originally posted by @hazendaz in #3753
Regression from #3753.
I couldn't find any BugReporter in maven plugin code, so I assume all output is generated somehow by
FindBugs2created viaAntBuilderhere:https://github.com/spotbugs/spotbugs-maven-plugin/blob/8bedb8ee38971883cd4fcbd2801bc2a959907bc4/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy#L1157C50-L1158
This should call
FindBugs2.main()and this should callTextUICommandLineand it should actually be configured herespotbugs/spotbugs/src/main/java/edu/umd/cs/findbugs/TextUICommandLine.java
Lines 665 to 667 in a3667d7
I believe
-adjustPriorityis not (always) given by maven. That would result in not createdPriorityAdjusterinstance. As a workaround, one can try to use something likeedu.umd.cs.findbugs.detect.CheckCalls=+0value for-adjustPriorityargument (shouldn't change anything except thatPriorityAdjusterwould be created).I will try to provide a fix for
TextUICommandLinenow.