Fix broken links when using dirhtml builder#1060
Merged
larsoner merged 7 commits intosphinx-gallery:masterfrom Jan 3, 2023
Merged
Fix broken links when using dirhtml builder#1060larsoner merged 7 commits intosphinx-gallery:masterfrom
larsoner merged 7 commits intosphinx-gallery:masterfrom
Conversation
Contributor
I think in order to un-block it like this we need to test it to make sure it succeeds without error. The easiest way to add such a test would probably be to run the |
Contributor
Author
|
I have added a simple |
Contributor
No I don't think that's necessary. I'll try to push a commit to make CIs happy, at the very least CircleCI is protecting against unregistered/new users... |
* upstream/master: MAINT: Update CIs (sphinx-gallery#1061) BUG: Remove ignore blocks when remove_config_comments=True (sphinx-gallery#1059)
Contributor
|
All green after a few style fixes and making the code more DRY, thanks @mgoulao ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea of this PR is to develop a better solution to #921.
dirhtmlblocking and associated testdirectives.visit_imgsg_htmlto supportdirhtmlspecial caseI'm unaware of any other problem related to using the
dirhtmlbuilder.