Conversation
|
Okay as part of the fixes I put the Plotly example in its own folder, which I think makes it more discoverable like PyVista and mayavi @lucyleeow feel free to merge if you're happy |
lucyleeow
left a comment
There was a problem hiding this comment.
Thanks for doing this. Looks good, and I agree separating the plotly example is a good idea. I just had some questions.
| - job: Skip | ||
| pool: | ||
| vmImage: 'ubuntu-18.04' | ||
| vmImage: 'ubuntu-latest' |
There was a problem hiding this comment.
Question - what does this job do?
There was a problem hiding this comment.
Just decides if all other steps should be skipped based on [skip azp] or [azp skip] being in the commit message
There was a problem hiding this comment.
Thanks, sorry my mis-understanding was more why would we need to specify/change the vmImage since this is just doing the skip?
There was a problem hiding this comment.
Eventually we'd need to once they retire 18.04. by using latest, we hopefully won't need to update it again
| sudo apt-get install --fix-missing python3-numpy python3-matplotlib python3-pip python3-coverage optipng graphviz \ | ||
| libxkbcommon-x11-0 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-xinerama0 libxcb-xfixes0 libopengl0 libegl1 libosmesa6 mesa-utils libxcb-shape0 | ||
| python3 -m pip install --upgrade pip setuptools wheel | ||
| python3 -m pip install -r dev-requirements.txt |
There was a problem hiding this comment.
Do we want the | cat at the end still?
There was a problem hiding this comment.
I don't think so, the output is easy enough to read without it
| @@ -19,7 +19,7 @@ if [ "$DISTRIB" == "conda" ]; then | |||
| PIP_DEPENDENCIES="$@" | |||
| PIP_DEPENDENCIES="$PIP_DEPENDENCIES sphinx_rtd_theme check-manifest" | |||
| if [ "$PYTHON_VERSION" != "3.7" -o "$LOCALE" != "C" ]; then | |||
There was a problem hiding this comment.
I don't think we have any azure python 3.7 jobs now...?
| python3 -m pip install -r dev-requirements.txt | ||
| python3 -m pip install "vtk<9.2" pyqt5 | ||
| python3 -m pip install --no-build-isolation mayavi | ||
| python3 -c "import faulthandler; faulthandler.enable(); from mayavi import mlab; mlab.test_plot3d()" |
There was a problem hiding this comment.
Maybe a comment as to why this is needed? 😬
| libxkbcommon-x11-0 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-xinerama0 libxcb-xfixes0 libopengl0 libegl1 libosmesa6 mesa-utils libxcb-shape0 | ||
| python3 -m pip install --upgrade pip setuptools wheel | ||
| python3 -m pip install -r dev-requirements.txt | ||
| python3 -m pip install "vtk<9.2" pyqt5 |
There was a problem hiding this comment.
Stupid question - don't we install these above in azure-pipelines.yml here: https://github.com/sphinx-gallery/sphinx-gallery/pull/1046/files#diff-7915b9b726a397ae7ba6af7b9703633d21c031ebf21682f3ee7e6a4ec52837a5R62
There was a problem hiding this comment.
Not sure. At some point a bigger refactoring of CIs to unify installations would be nice. But not in this PR :)
There was a problem hiding this comment.
... oh actually, no we don't install them there. That is for the Windows job. These lines are used by the Linux job
* upstream/master: Reorder paragraphs in the minigallery documentation (sphinx-gallery#1048) Update advanced usage examples (sphinx-gallery#1045)
* upstream/master: MAINT: Fix CIs (sphinx-gallery#1046) Reorder paragraphs in the minigallery documentation (sphinx-gallery#1048)
|
Thanks for answering my questions! |
No description provided.