Fix "subsection_index_toctree referenced before assignment"#1035
Merged
larsoner merged 2 commits intosphinx-gallery:masterfrom Oct 18, 2022
OverLordGoldDragon:patch-1
Merged
Fix "subsection_index_toctree referenced before assignment"#1035larsoner merged 2 commits intosphinx-gallery:masterfrom OverLordGoldDragon:patch-1
subsection_index_toctree referenced before assignment"#1035larsoner merged 2 commits intosphinx-gallery:masterfrom
OverLordGoldDragon:patch-1
Conversation
Produced with `'nested_sections': False`: ``` Handler <function generate_gallery_rst at 0x0000021152A7A440> for event 'builder-inited' threw an exception (exception: local variable 'subsection_index_toctree' referenced before assignment) ``` Unsure if this reflects intent, feel free to edit.
Contributor
|
@alexisthual can you look? I think this has to do with your nesting changes |
Contributor
Author
|
Can this merge sometime soon? I struggle remote installing from multiple commits. I do think it's a simple bug, if cond0:
if cond1:
var = 1
print(var)is guaranteed to fail for |
Contributor
Author
|
Apparently full equivalency mattered, rewrote and added doc to reflect both conds. The failure's again checksums. Also guess I'll install from fork in meantime. |
Contributor
|
Agreed this makes sense. It would be great to have a regression test, but we clearly didn't hit these lines before so I don't think the onus is on you here :) Thanks @OverLordGoldDragon ! |
Contributor
|
Sorry I'm a bit late in the game here, but the fix seems ok to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Produced with
'nested_sections': False:Unsure if this reflects intent, feel free to edit.