fix: raise an exception if multiple bind parameters aren't an array#527
Merged
flavorjones merged 1 commit intomainfrom Apr 19, 2024
Merged
fix: raise an exception if multiple bind parameters aren't an array#527flavorjones merged 1 commit intomainfrom
flavorjones merged 1 commit intomainfrom
Conversation
tenderlove
approved these changes
Apr 19, 2024
Make sure Database#execute, #query, and #execute_batch raise an ArgumentError to avoid silent problems. This should have been done in ae12904
f61da5e to
1168b9c
Compare
threeplanetssoftware
added a commit
to threeplanetssoftware/apple_cloud_notes_parser
that referenced
this pull request
May 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure Database#execute, #query, and #execute_batch raise an ArgumentError to avoid silent problems.
This should have been done in ae12904
Related to #525
A potential alternative is to revert ae12904