Add SQLite3.status to call sqlite3_status#520
Merged
flavorjones merged 3 commits intosparklemotion:mainfrom Apr 16, 2024
Merged
Add SQLite3.status to call sqlite3_status#520flavorjones merged 3 commits intosparklemotion:mainfrom
flavorjones merged 3 commits intosparklemotion:mainfrom
Conversation
This function is useful for understanding the runtime performance of sqlite. This is a very thin layer on top of the sqlite3 library's function, so it allows full usage of it from Ruby.
52c2e35 to
8de7be0
Compare
Member
|
@wjlroe Thank you for this contribution! I've added a commit with some documentation for the method, and tweaked the test, but otherwise this seems great. Thank you! |
8de7be0 to
ecfae5a
Compare
Member
|
I've also updated |
ecfae5a to
c0e5c68
Compare
and add to the changelog
and fully document the method.
c0e5c68 to
b14a84e
Compare
Contributor
Author
|
@flavorjones Thanks for improving this! It looks like some of the tests are failing because it's returning 0 sometimes, which I was a bit unsure about when I wrote that test - that test might have to do something via sqlite before enquiring about memory to ensure it's non-zero - what do you think? |
Member
|
@wjlroe Yep, I updated the tests to test for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is useful for understanding the runtime performance of sqlite.
This is a very thin layer on top of the sqlite3 library's function, so it allows full usage of it from Ruby.
I've tested with
./bin/build-gemsand it built fine and the tests passed.