Fix writing to an IO with no external_encoding#2753
Merged
flavorjones merged 1 commit intosparklemotion:mainfrom Jan 4, 2023
Merged
Fix writing to an IO with no external_encoding#2753flavorjones merged 1 commit intosparklemotion:mainfrom
flavorjones merged 1 commit intosparklemotion:mainfrom
Conversation
A file-IO has no external_encoding by default, so that rb_to_encoding() fails with a TypeError. This regression was introduces in commit 2e260f5. Fixes sparklemotion#2752 Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A file-IO has no external_encoding by default, so that rb_to_encoding() fails with a TypeError.
This regression was introduces in commit 2e260f5.
Fixes #2752