Add support for providing *tpm.TPM instance when creating a TPMKMS
#885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds a new method that allows to get the TPM instance used by the tpmkms.
This commit adds tpmkks.NewWithTPM that initializes the tpmkms with a given *tpm.TPM.
032419e to
9a00bef
Compare
*tpm.TPM instance when creating a TPMKMS instance
*tpm.TPM instance when creating a TPMKMS instance*tpm.TPM instance when creating a TPMKMS
This commit removes the legacy build tags because the latest version of golangci-lint show errors.
hslatman
reviewed
Nov 3, 2025
Member
hslatman
left a comment
There was a problem hiding this comment.
Looking pretty nice overall! Looking forward to try it 😄
hslatman
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds a new constructor to
tpmkmsthat allows to initializes theTPMKMSwith a given*tpm.TPM. instance.Note that most of the file changes are because the new version of golangci-lint complains with legacy build tags, e.g.
// +build windows