-
Notifications
You must be signed in to change notification settings - Fork 29
Add CreateDecrypter support to AWS KMS
#702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7ded556 to
7c54eed
Compare
|
I've just done a quick encrypt/decrypt test against AWS with a patched $ step-kms-plugin encrypt --oaep --in message.txt --no-label --kms 'awskms:' 'awskms:key-id=<key-id>;region=<region>'
// encrypted output in base64 format
$ step-kms-plugin decrypt --oaep --in encrypted.bin --no-label --kms 'awskms:' 'awskms:key-id=<key-id>;region=<region>'
// decrypted output |
Yup I confirm. The only requirement is to have an RSA key configured with |
Indeed. I've seen that before with GCP Cloud KMS, and is considered a good practice. In its current form we generally don't check the key capabilities in the KMS implementations before performing crypto operations. An invalid key will thus result in an error upon trying a decryption, whereas it may be an option to check the capabilities before trying to use the key for a purpose it's not configured for. Maybe we'll add something for that in the future 🙂 For your use case you'll thus need the SCEP decrypter configured in addition to the RSA intermediate for signing. If the rest of your stack allows for it, you could also opt for an ECDSA intermediate signer, and the RSA SCEP decrypter. |
7c54eed to
afd9451
Compare
147982a to
3018ea0
Compare
|
Is seems there's a lot of places where a new context pops out instead of being propagated. Is that intentional? |
These are the two I see:
|
maraino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.