Replace conflicting nssdb objects #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing certificates and keys into an NSS db replace any with a conflicting CKA_ID, which holds the certs subject key id. Also fix bug with generating initialization vector for aes256-cbc. Also fix pk1sign test that allowed bug to go undetected.
areed
commented
Feb 7, 2025
maraino
requested changes
Feb 7, 2025
Contributor
maraino
left a comment
There was a problem hiding this comment.
Deleting objects is always dangerous, I think we should consider what the NSS tools do in those cases.
To me, it should be an option of the user, in this case, by the application using this package. But it would be ok, if that is the behavior used by the default tools used to manage those databases.
maraino
approved these changes
Feb 10, 2025
Contributor
maraino
left a comment
There was a problem hiding this comment.
Although the behavior of deleting objects is not ideal, I think it should be an option in the app using this, but as it's the default behavior in pk12util, let's go with this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing certificates and keys into an NSS db replace any with a conflicting CKA_ID, which holds the certs subject key id.
Add new DeleteCertificatesByName command to clean up certificates and their keys by nickname.
Also fix bug with generating initialization vector for aes256-cbc. Also fix pk1sign test that allowed bug to go undetected.
💔Thank you!