Load the most recent certificate#952
Merged
Merged
Conversation
This commit changes the logic of MacKMS LoadCertificate and LoadCertificateChain to return the certificate with the newer NotBefore as long as it is before the current time.
3251024 to
9a16877
Compare
dopey
reviewed
Feb 18, 2026
dopey
previously approved these changes
Feb 18, 2026
dopey
approved these changes
Feb 18, 2026
hslatman
reviewed
Feb 18, 2026
Comment on lines
+164
to
+167
| // NewPublicKey validates that the point is on the curve | ||
| if _, err := ecdhCurve.NewPublicKey(uncompressed); err != nil { | ||
| return nil, errors.New("invalid EC key: point (x, y) does not lie on the curve") | ||
| } |
Member
There was a problem hiding this comment.
There can be other conditions returning an error. Technically, I guess it's correct to state that they're not on the curve for these cases, but we're losing some details by not wrapping the error returned from NewPublicKey. It's a pity there don't seem to be sentinel errors for these.
Contributor
Author
There was a problem hiding this comment.
There was a linter error, so I've changed the implementation but I kept the message.
if !curve.IsOnCurve(key.X, key.Y) {
return nil, errors.New("invalid EC key: point (x, y) does not lie on the curve")
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the logic of MacKMS LoadCertificate and LoadCertificateChain to return the certificate with the newer NotBefore as long as it is before the current time.
This commit also fixes the linter errors that appear with the new version of golangci-lint.