-
Notifications
You must be signed in to change notification settings - Fork 185
Closed
Labels
questionFurther information is requestedFurther information is requested
Description
Description
This issue is similar to #131, but applies when using a bot instead of a webhook. When using the action behind a corporate proxy (e.g. on self-hosted runners), connection will time out because the proxy configuration is not respected.
What type of issue is this? (place an x in one of the [ ])
- bug
- enhancement (feature request)
- question
- documentation related
- example code related
- testing related
- discussion
Requirements (place an x in each of the [ ])
- I've read and understood the Contributing guidelines and have done my best effort to follow them.
- I've read and agree to the Code of Conduct.
- I've searched for any related issues and avoided creating a duplicate issue.
Bug Report
Reproducible in:
package version: 1.24.0
node version: 16
OS version(s): Ubuntu 22.04
Steps to reproduce:
- Set up a proxy for outgoing HTTPS traffic, and block all other outgoing HTTPS traffic
- Point HTTPS_PROXY / https_proxy to the proxy
- Run the action using bot token and channel ID
Expected result:
The message is sent
Actual result:
The actions fails due to connection timeout
Attachments:
Run slackapi/slack-github-action@v1.24.0
with:
channel-id: xxxxxxxxx
slack-message: XXXXXXXXX
env:
SLACK_BOT_TOKEN: ***
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT xxx.xxx.xxx.xxx:443
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT yyy.yyy.yyy.yyy:443
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT yyy.yyy.yyy.yyy:443
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT zzz.zzz.zzz.zzz:443
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT www.www.www.www:443
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT yyy.yyy.yyy.yyy:443
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT yyy.yyy.yyy.yyy:443
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT www.www.www.www:443
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT yyy.yyy.yyy.yyy:443
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT xxx.xxx.xxx.xxx:443
[WARN] web-api:WebClient:0 http request failed connect ETIMEDOUT www.www.www.www:443
Error: Error: A request error occurred: connect ETIMEDOUT yyy.yyy.yyy.yyy:443
@slack/web-api's WebClient already supports sending a custom agent (and intentionally disables Axios' proxy detection). I don't think this is a hard problem to fix, but I couldn't figure out how to write satisfactory tests for it.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
questionFurther information is requestedFurther information is requested