feat(cli-hooks): output node warnings to stderr for debugging outputs#2152
Merged
feat(cli-hooks): output node warnings to stderr for debugging outputs#2152
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2152 +/- ##
==========================================
- Coverage 91.94% 91.94% -0.01%
==========================================
Files 38 38
Lines 10330 10328 -2
Branches 652 652
==========================================
- Hits 9498 9496 -2
Misses 820 820
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
mwbrooks
approved these changes
Feb 23, 2025
Member
mwbrooks
left a comment
There was a problem hiding this comment.
✅ LGTM!
🚀 Let's publish a release of this on Monday!
Member
Author
|
@mwbrooks Thanks so much! I must've been following a different calendar, but am excited to be outputting warnings that do appear 👻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts changes made in #2096 that hide Node warnings.
The latest Slack CLI version v2.33.0 has improved handling of
stderrand will now write unexpected output to debug logs instead of erroring when parsing hook responses! 🎉Preview
node_warnings.mov
Reviewers
With these changes checked out and installed to an app using
@slack/cli-hooks, run the following commands with Node v23.2.0:Requirements