web-api(feat): add support for conversations.requestShared approve , deny and list APIs#1843
web-api(feat): add support for conversations.requestShared approve , deny and list APIs#1843
conversations.requestShared approve , deny and list APIs#1843Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
+ Coverage 91.61% 91.63% +0.01%
==========================================
Files 37 37
Lines 9924 9946 +22
Branches 633 633
==========================================
+ Hits 9092 9114 +22
Misses 820 820
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
02dfdaf to
cd4a8f5
Compare
conversations.requestShared approve and deny APIsconversations.requestShared approve , deny and list APIs
…` and `deny` APIs
…API request arguments.
cd4a8f5 to
22511ac
Compare
misscoded
left a comment
There was a problem hiding this comment.
Left one question about an optional property, but all looks in order to me. 
| } | ||
| interface Message { | ||
| /** @description A message to send to the user who requested the invite. */ | ||
| message?: string; |
There was a problem hiding this comment.
I'm surprised this is optional, given it's the only property?
There was a problem hiding this comment.
I could easily fold this into the deny method's arguments directly; the reason it is its own interface right now is that I factored it out when, earlier in these APIs' pilot, there were other methods (that the team decided not to ship) that used the same property, so instead of repeating it across different API argument interfaces, I factored it out and reused them. But, I just removed all those other APIs since they are not public yet.
I can fold that back into just the Deny arguments - let me know!
There was a problem hiding this comment.
No need: I trust your judgement! At first glance, it's just surprising that a Message interface wouldn't feature the message prop. 😂
Carry on!
This PR adds support for two new APIs: