Accept URL and {file: URL} (#23)

fisker · web-flow · commit 7dd1173039a8 · 2025-11-23T14:10:51.000+07:00
diff --git a/index.test-d.ts b/index.test-d.ts
@@ -30,6 +30,10 @@ expectType<EditorInfo>(
 			line: 10,
 			column: 2,
 		},
+		new URL('file://path/to/file'),
+		{
+			file: new URL('file://path/to/file'),
+		},
 	]),
 );
 
diff --git a/package.json b/package.json
@@ -52,7 +52,7 @@
 	"dependencies": {
 		"env-editor": "^1.1.0",
 		"execa": "^9.3.0",
-		"line-column-path": "^3.0.0",
+		"line-column-path": "^4.0.0",
 		"open": "^10.1.0"
 	},
 	"devDependencies": {
diff --git a/readme.md b/readme.md
@@ -49,7 +49,7 @@ Open the given files in the user's editor at specific line and column if support
 
 #### files
 
-Type: `Array<string | object>`
+Type: `Array<string | URL | object>`
 
 Items should be in the format `foo.js:1:5` or `{file: 'foo.js', line: 1: column: 5}`.
 
diff --git a/test.js b/test.js
@@ -1,12 +1,16 @@
+import url from 'node:url';
+import path from 'node:path';
 import test from 'ava';
 import {getEditorInfo} from './index.js';
 
 const fixtureFiles = [
 	'unicorn.js:10:20',
 	'rainbow.js:43:4',
 ];
+const fixturePath = path.resolve('/foo.js');
+const fixtureUrl = url.pathToFileURL(fixturePath);
 
-test('object input', t => {
+test('files', t => {
 	t.deepEqual(
 		getEditorInfo(
 			[
@@ -31,6 +35,29 @@ test('object input', t => {
 			isTerminalEditor: false,
 		},
 	);
+	t.deepEqual(
+		getEditorInfo(
+			[
+				fixtureUrl,
+				{
+					file: fixtureUrl,
+					line: 43,
+					column: 4,
+				},
+			],
+			{
+				editor: 'sublime',
+			},
+		),
+		{
+			binary: 'subl',
+			arguments: [
+				`${fixturePath}:1:1`,
+				`${fixturePath}:43:4`,
+			],
+			isTerminalEditor: false,
+		},
+	);
 });
 
 test('editor - generic', t => {
