const args = ['access', 'list collaborators', packageName];

You have a typo. Should be:

const args = ['access', 'list', 'collaborators', packageName];

Make sure that npm test passes locally and to review your own diff

Thank you for your feedback!
I had troubles running the tests on my (windows) machine yesterday, found a workaround but that clearly did not work.
I changed the line as you suggested, I also changed two tests of the prerequisites-tasks.js because it used the old npm access subcommands (not committed yet).
But running the tests (with the help of cross-env) now, I'm getting the following error with this index » version is invalid and index » version is pre-release:

TimeoutError {
     context: {},
     message: 'Connection to npm registry timed out',
 }

So, I now committed the changes to the test files as well and now the Github Actions tests run without error on my forked repo 👍

Hey @DerTimonius, looks like you're pretty close. Anything I can do to help?

Hey @schuchard , thank you for your offer!
I did not have time in the last two days to take a look into this again, and now I added the --json flag. I'm not sure if I missed anything else though, so if I did, any help would be appreciated 😃

Hi @sindresorhus, is there anything else needed to merge this PR? Thanks.

I don't know why the tests are failing now with an error message that should be solved (npm access list not a valid argument).

Maybe it's failing on an older version of npm? (eg. one that does not yet have npm access list ... commands)

Maybe it should be conditional on what version of npm is being run.

Seems likely. NPM 9 brought a breaking change to npm access:

npm access subcommands have been renamed

If this package intends to support npm < 9, conditional logic and tests are needed.

I'm making progress: I implemented a npm version check, so that the correct subcommands are used.

Currently I have one failing test left:

prerequisite-tasks › should fail when user is not authenticated at external registry

142:   await t.throwsAsync(run(testedModule('2.0.0', {name: 'test', version:…
   143:     {message: 'You do not have write permissions required to publish th…

  Promise resolved with:

  undefined

Locally, I always get a Timeout Error on this test though...

Any hints on what I'm missing?

So this is the error message that you're getting:

  1 test failed

  prerequisite-tasks › should fail when user is not authenticated at external registry

  /home/runner/work/np/np/test/prerequisite-tasks.js:145

   144:   process.env.NODE_ENV = 'P';                                           
   145:   await t.throwsAsync(run(testedModule('2.0.0', {name: 'test', version:…
   146:     {message: 'You do not have write permissions required to publish th…

  Promise rejected with unexpected exception:

  Error {
    context: {},
    message: 'Git tag `v2.0.0` already exists.',
  }

  Expected message to equal:

  'You do not have write permissions required to publish this package.'

  Object.exports.verifyTagDoesNotExistOnRemote (source/git-util.js:206:9)
  Task.task (source/prerequisite-tasks.js:88:5)

This indicates that the collaborators JSON here actually passed the test:

You could try logging out this value to see if this is truly the case.

Or, second idea: maybe the check for list collaborators is not being run at all... 🤔 Seems like you have a weird pattern here:

To me testArgs should be an array, not a function...

Last tip, the order of your arguments in these three places is different:

Thank you for your inputs @karlhorky !

After logging out a few things, I narrowed the problem down to an issue with the external registry:

• The collaborators functions return false and the task does not get to the permissions variable.
• Logging the args inside the collaborators function returns a valid array.
• But since it returned false, the only place where this could happen is here in source/npm/util.js, lines 78-88:

try {
		const {stdout} = await execa('npm', args);
		return stdout;
	} catch (error) {
		// Ignore non-existing package error
		if (error.stderr.includes('code E404')) {
			return false;
		}

		throw error;
	}

So, logging out the error here gives me this message:

'npm ERR! code E404\n' +
    'npm ERR! 404 Not Found - GET http://my.io/-/package/test/collaborators\n' +
    '\n' +
    'npm ERR! A complete log of this run can be found in:\n'

But the command is this:

npm access list collaborators --json test --registry http://my.io

I don't know where the -/package/test/collaborators is coming from, it's not added in the code... (or if this is even the issue).

Regarding this:

Or, second idea: maybe the check for list collaborators is not being run at all... 🤔 Seems like you have a weird pattern here:

np/test/prerequisite-tasks.js

Lines 11 to 14 in 6d4f036

	const testArgs = async () => {
	const npmVersion = await versionNpm();
	return semver.satisfies(npmVersion, '>=9.0.0') ? ['list collaborators', ' --json'] : ['ls-collaborators', ''];
	};

To me testArgs should be an array, not a function...

You're right, I tried to do is as an array in the first place, but wasn't able to for some reason. Put it inside the test now, just to be sure.

So, I removed the conditional arguments in the tests since it does not have any effect on the executed code, now it's again this

command: 'npm access ls-collaborators test',

instead of:

command: `npm access ${testArgs[0]} test${testArgs[1]}',

I suspected that maybe this change could be the reason the tests are failing.
Also I moved the --json flag once again.

Hey @sindresorhus, is there anything else I have to change?